stefanfoulis / django-phonenumber-field

A django model and form field for normalised phone numbers using python-phonenumbers
MIT License
1.48k stars 318 forks source link

python-phonenumbers should be a requirement #606

Closed arveitch closed 5 months ago

arveitch commented 5 months ago

I think you just need a setup.py with python-phonenumbers and the required version specified.

That way it is automatically installed for anyone who installs this package from pip

Thanks for your work on a great product!

francoisfreitag commented 5 months ago

Hi,

The phonenumbers package actually provides two alternatives, https://django-phonenumber-field.readthedocs.io/en/latest/#choosing-a-phonenumbers-provider, see https://github.com/daviddrysdale/python-phonenumbers?tab=readme-ov-file#memory-usage. That’s why phonenumbers is not a required package, because phonenumberslite may be sufficient for most users, and is considerably smaller.