Use new REST JSON API for BulkSMS

stefanfoulis / django-sendsms

A simple API to send SMS messages. It is modeled after the django email api.

MIT License

262 stars 99 forks source link

Use new REST JSON API for BulkSMS #46

Closed denizdogan closed 5 years ago

denizdogan commented 5 years ago

Breaking changes:

SENDSMS_BULKSMS_USERNAME replaced by SENDSMS_BULKSMS_TOKEN_ID
SENDSMS_BULKSMS_PASSWORD replaced by SENDSMS_BULKSMS_TOKEN_SECRET

Fixes #44

ghost commented 5 years ago

DeepCode Report (#fafc15)

DeepCode analyzed this pull request. There are no new issues.

denizdogan commented 5 years ago

The tox suite is failing because of the Celery requirement probably not supporting Python 2.7

stefanfoulis commented 5 years ago

Thanks for this @denizdogan 🙇

Does bulksms currently still support the old api? (I am trying to figure out if we should release this with a bigger version bump because it is a breaking change in the settings for existing bulksms users, or if it is currently broken for bulksms anyway and this is basically a bugfix.)

denizdogan commented 5 years ago

@stefanfoulis The old API is deprecated and no longer actively worked on, but still works just fine. I haven't been able to find any information about when they're planning on shutting it off.

stefanfoulis commented 5 years ago

I rebased in #49 and merged.