search

stefang / Frame-Accurate-HTML5-Video-Thing

A prototype jQuery plug in that creates frame accurate controls for an HTML5 video element
36 stars 8 forks source link

Tidy up jquery.videoControls.js #2

Closed rosadurante closed 10 years ago

rosadurante commented 10 years ago

I try to put the code a bit more clear and also remove all violations of JShint.

stefang commented 10 years ago

Hi Rosa. I've looked at your code and it's fine but it's broken the play head dragging. If you can fix that issue and keep the improvements I'd be happy to merge in your changes.

Stefan

On 8 Oct 2013, at 21:34, Rosa Durante wrote:

I try to put the code a bit more clear and also remove all violations of JShint.

You can merge this Pull Request by running

git pull https://github.com/rosUnix/Frame-Accurate-HTML5-Video-Thing chore/jshint Or view, comment on, or merge it at:

https://github.com/stefang/Frame-Accurate-HTML5-Video-Thing/pull/2

Commit Summary

Adding .jshintrc Tidy up videoControls file and linting File Changes

A .jshintrc (50) M js/jquery.videoControls.js (483) Patch Links:

https://github.com/stefang/Frame-Accurate-HTML5-Video-Thing/pull/2.patch https://github.com/stefang/Frame-Accurate-HTML5-Video-Thing/pull/2.diff

rosadurante commented 10 years ago

Sure thing! So sorry for that. I'll fix it asap :)