stefangabos / Zebra_Datepicker

A super-lightweight, highly configurable, cross-browser date time picker jQuery plugin
https://stefangabos.github.io/Zebra_Datepicker/
Other
398 stars 183 forks source link

CSS Deprecation Warnings when using SCSS #157

Closed Damo1155 closed 4 years ago

Damo1155 commented 4 years ago

I've recently brought the Zebra Datepicker into a couple of our projects via NPM.

Upon including the appropriate references and running the compiler we get the following warning.

DEPRECATION WARNING on line 8, column 8 of <PATH TO SASS FILE>: Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.

All our other imports into the SCSS file don't import CSS files directly and instead only reference the SCSS counterpart. After doing some digging around our actual issue is the library doesn't support SCSS.

Are there any plans on migrating the CSS to SCSS or at the very least supporting both SCSS and CSS?

stefangabos commented 4 years ago

Zebra_Datepicker is built with SCSS but the scss files are not included with the release files. I will do a release later today with the sass files included. thanks for the heads-up

Damo1155 commented 4 years ago

Thanks for the update, I look forward to getting the latest version.

stefangabos commented 4 years ago

i published a release (1.9.15) which contains the SASS files. have a look and let me know if it works

Damo1155 commented 4 years ago

Thanks for the update.

I’ve just finished work for the day so I’ll make this my first task tomorrow morning.

Damo1155 commented 4 years ago

I've pulled in the latest changes and can confirm it fixes our issue.

Thanks for the quick turnaround.