search

stefangabos / Zebra_Form

A jQuery augmented PHP library for creating secure HTML forms and validating them easily
Other
98 stars 49 forks source link

Prevent duplicate attributes #28

Open JeffBuckles opened 8 years ago

JeffBuckles commented 8 years ago

Non-array control attributes are concatenated with a space delimiter. This caused me some problems where I would end up with multiple occurrences of some attribute values. Added some checking to confirm the attribute value is not already present before adding it.

There may be consequences or implications of doing this that I'm not aware of, so please consider carefully.

Also noticed my braces style does not match your standard (I use braces even if only one line of code in the block). Let me know if you want me to fix it.

Thanks,

stefangabos commented 8 years ago

Can you please give me a real-life example where this is causing problems? I've used this only for adding multiple classes to an element, but having the same class added multiple times is not an issue so I've never considered adding this check. Other attributes usually accept a single value...

JeffBuckles commented 8 years ago

I had to think about this for a while because I made the change in my local copy back in February, and only now got around to reviewing how to do pull requests in GitHub...

This is a consequence of how I am processing the form after validation (the form is always re-displayed for further editing).

Various conditions may cause controls to be disabled or re-enabled. Because multiple conditions were checked, it sometimes caused the "disabled" class to be added more than once, for example. This meant that to re-enable the control I had to check each time for multiple occurrences of 'disabled' in the class attribute.

Rather than fixing my code to check for duplicates everywhere I touched the attributes (or re-write the whole thing with a more sensible structure), it was more convenient to prevent the duplication from occurring at all.

I'm happy to keep this as a local patch if it's not an issue for anyone else.

Thanks and Best Regards, -- Jeff

On 5/26/2016 1:54 AM, Stefan Gabos wrote:

Can you please give me a real-life example where this is causing problems? I've used this only for adding multiple classes to an element, but having the same class added multiple times is not an issue so I've never considered adding this check. Other attributes usually accept a single value...

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/stefangabos/Zebra_Form/pull/28#issuecomment-221814718