search

stefangabos / world_countries

Constantly updated lists of world countries and their associated alpha-2, alpha-3 and numeric country codes as defined by the ISO 3166 standard, available in CSV, JSON , PHP, SQL and XML formats, in multiple languages and with national flags included; also available are the ISO 3166-2 codes of provinces/ states associated with the countries
http://stefangabos.github.io/world_countries/
Other
1.35k stars 375 forks source link

fix simplified Chinese and traditional Chinese mix #32

Closed sun-jiao closed 4 years ago

sun-jiao commented 4 years ago

I saw your comment in another pull request, you have a script, but I don't know if your script get data from wiki code or the webpage.

The Chinese Wikipedia can auto convert between traditional and simplified Chinese, so the country names in wiki code may be mixed.(and it's not allowed to change between them.) If your script get data from webpage, that will be great, you should just change the target URL to a concerted page. If you get data from wiki code, a manual conversion will be needed.

stefangabos commented 4 years ago

This is the link from where I am taking country names. Obviously, I take the country names by parsing the HTML code in the page, but whatever you see is the same as what there is in the page's code.

stefangabos commented 4 years ago

Can you please give me a link to that page set up so that it shows what I need to parse?

stefangabos commented 4 years ago

Apparently what I see when I am accessing the page is in - according to Google Translate - Chinese (Traditional)

stefangabos commented 4 years ago

Additionally, switching via Google Translate from traditional to simplified Chinese makes no difference in country names - at least that is how it seems to me

sun-jiao commented 4 years ago

This is the link from where I am taking country names. Obviously, I take the country names by parsing the HTML code in the page, but whatever you see is the same as what there is in the page's code.

Simplified Chinese: https://zh.wikipedia.org/zh-cn/ISO_3166-1

stefangabos commented 4 years ago

done. do i have to include other variations of the Chinese language? Like zh-tw, zh-hk, zh-mo, zh-my, etc. ? if so, which ones should I add? thank you for helping!

sun-jiao commented 4 years ago

done. do i have to include other variations of the Chinese language? Like zh-tw, zh-hk, zh-mo, zh-my, etc. ? if so, which ones should I add? thank you for helping!

I think it's a good idea to add zh-tw and zh-hk version, and no need to add other variants. https://zh.wikipedia.org/zh-tw/ISO_3166-1 https://zh.wikipedia.org/zh-hk/ISO_3166-1

zh-mo is almost same as zh-hk. zh-my and zh-sg are almost same as zh-cn. Can you please update the cn version again? I just updated the simplified Chinese name of 876,wf,wlf in Wikipedia.

sun-jiao commented 4 years ago

done. do i have to include other variations of the Chinese language? Like zh-tw, zh-hk, zh-mo, zh-my, etc. ? if so, which ones should I add? thank you for helping!

btw, Would you like to add svg version of flags? You can get filenames of them from the html, and find them in wikimedia commons.

stefangabos commented 4 years ago

i have reprocessed the wikipedia page and updated the country name for the one you changed. i will also include the other variations of the chinese language in the coming days. good idea about the svg flags, i will also look into that. thanks a lot for all your support!

sun-jiao commented 4 years ago

i have reprocessed the wikipedia page and updated the country name for the one you changed. i will also include the other variations of the chinese language in the coming days. good idea about the svg flags, i will also look into that. thanks a lot for all your support!

Thank you for this pleasant discussion and for your excellent project.