search

stefangabos / world_countries

Constantly updated lists of world countries and their associated alpha-2, alpha-3 and numeric country codes as defined by the ISO 3166 standard, available in CSV, JSON , PHP, SQL and XML formats, in multiple languages and with national flags included; also available are the ISO 3166-2 codes of provinces/ states associated with the countries
http://stefangabos.github.io/world_countries/
Other
1.35k stars 375 forks source link

Add Traditional Chinese translation #35

Closed hirakujira closed 3 years ago

hirakujira commented 3 years ago

I added Traditional Chinese (zh_TW) translation.

hirakujira commented 3 years ago

It's based on https://zh.wikipedia.org/wiki/ISO_3166-1 but has minor changes because some names are not updated in this list.

For example: NL (Netherlands) announced "尼德蘭" should be the official Chinese translation since 2020 but wikipedia still shows "荷蘭", which means "Holland".

Also, TW (Taiwan, Province of China) translated to "台灣", because the translation of zh_TW is for people in Taiwan and we don't agree that Taiwan is a province of China.

stefangabos commented 3 years ago

Since the lists are compiled automatically from Wikipedia, I can't take pull requests. But, what I did was to add https://zh.wikipedia.org/wiki/ISO_3166-1 to my lists of sources to fetch and I added the changes you requested for the Netherlands and for Taiwan.

Please have a look - it's in the data/zh folder. I would appreciateit if you'd change the naming for Netherlands on the Wikipedia page, so I don't have to always overwrite it.

Thank you!

stefangabos commented 3 years ago

I added it also to http://stefangabos.github.io/world_countries/

hirakujira commented 3 years ago

Hello, I'm sorry that I made a mistake, Netherland can be pulled directly from Wikipedia. No need modifications. The only thing that need to be changed manually is Taiwan.

And also, the data you fetched seems contains Simplified Chinese because Wikipedia shows Traditional Chinese on my computer automatically, but not on your side

Please fetch this URL instead: https://zh.wikipedia.org/zh-tw/ISO_3166-1, I'm sorry for the inconvenience and very appreciated for your patience.

stefangabos commented 3 years ago

Don't worry about it - thank you for your help! I updated the lists, please have a look

hirakujira commented 3 years ago

Yes, it's perfect now, thanks for your help!

stefangabos commented 3 years ago

I published a new release - 1.1.1, and it is now available via npm or from here Thank you!