Add new language: basque

stefangabos / world_countries

Constantly updated lists of world countries and their associated alpha-2, alpha-3 and numeric country codes as defined by the ISO 3166 standard, available in CSV, JSON , PHP, SQL and XML formats, in multiple languages and with national flags included; also available are the ISO 3166-2 codes of provinces/ states associated with the countries

http://stefangabos.github.io/world_countries/

Other

1.35k stars 375 forks source link

Add new language: basque #38

Closed erral closed 3 years ago

erral commented 3 years ago

Hi:

This project has been very useful for us to get the translations of the country names for a project.

Can you please add basque (eu) translations? The wikipedia page is up to date with official basque names, and if someone is missing I will update it right away:

stefangabos commented 3 years ago

Just found out very interesting stuff about the basque language!

Here's the stuff that's not ok

Curaçao, cw, 531, cuw
Saint Barthélemy, bl, 652, blm
Saint Martin (French part), mf, 663, maf
Sint Maarten (Dutch part), sx, 534, sxm
Svalbard and Jan Mayen, sj, 744, sjm

erral commented 3 years ago

I added those to the table. The wikipedia page for Svalbard and Jan Mayen is missing, but I will create it later today or tomorrow. I hope that it's not an obstacle to run your script.

stefangabos commented 3 years ago

No, those pages aren't required - just the entries on the ISO 3166 page; you can create the entries without having to make them as links

stefangabos commented 3 years ago

there's an error on the page - look for Txantiloi:Herrialde info Svalbard eta Jan Mayen

erral commented 3 years ago

Yep, we have just fixed the error and now the table should be completed.

stefangabos commented 3 years ago

Almost there. Looking in the history, i think you accidentally removed [Saint Kitts and Nevis, kn, 659, kna]. And still missing is [Bonaire, Sint Eustatius and Saba, bq, 535, bes] - I don't know why my script didn't show this to me the first time Thanks!

erral commented 3 years ago

I restored Saint Kittis and added Bonaire :)

stefangabos commented 3 years ago

Done! Note that Belgika and Belize are present twice, once at the bottom of the page (on Wikipedia, I mean) Thanks a lot for your help!

erral commented 3 years ago

I wonder why we had that on Wikipedia....

I fixed that, anyway. Thanks!

erral commented 3 years ago

Just one more thing, I have seen that you have added basque language with the "es-pv" code. I think that that's the code for the Basque region in Spain and not the code for the language, which is "eu". Can you check it? See: https://en.wikipedia.org/wiki/ISO_3166-2:ES

stefangabos commented 3 years ago

It is the ISO 3166 code

On Fri, 25 Sep 2020, 08:18 Mikel Larreategi, notifications@github.com wrote:

Just one more thing, I have seen that you have added basque language with the "es-pv" code. I think that that's the code for the Basque region in Spain and not the code for the language, which is "eu". Can you check it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stefangabos/world_countries/issues/38#issuecomment-698725290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFU6LMMO5MIDI4OIGBI7ZDSHQR33ANCNFSM4RYLL72Q .

erral commented 3 years ago

Yes but "basque" is a language and not a subdivision, right? It should be a ISO-639-1 code shouldn't it?

stefangabos commented 3 years ago

you are right. i am not at my desk but will be in an hour or so and i will fix it

On Fri, 25 Sep 2020, 09:22 Mikel Larreategi, notifications@github.com wrote:

Yes but "basque" is a language and not a subdivision, right? It should be a ISO-639-1 code shouldn't it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stefangabos/world_countries/issues/38#issuecomment-698745561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFU6LLTKHKDW6YI3OZ65W3SHQZK7ANCNFSM4RYLL72Q .

stefangabos commented 3 years ago

Should be good now

erral commented 3 years ago

Indeed. Thanks!!!

stefangabos commented 3 years ago

Thank you!