search

stefangabos / world_countries

Constantly updated lists of world countries and their associated alpha-2, alpha-3 and numeric country codes as defined by the ISO 3166 standard, available in CSV, JSON , PHP, SQL and XML formats, in multiple languages and with national flags included; also available are the ISO 3166-2 codes of provinces/ states associated with the countries
http://stefangabos.github.io/world_countries/
Other
1.35k stars 375 forks source link

Correct some german translations #5

Closed oliver-la closed 6 years ago

oliver-la commented 6 years ago

Currently the german translations are using the long form of country names. In my opinion it's cleaner and better to have the short instead of the long forms. This PR corrects some of these cases, but I most likely didn't catch everything.

For reference: https://de.wikipedia.org/wiki/Liste_der_Staaten_der_Erde

stefangabos commented 6 years ago

I am sorry but I cannot merge this pull request. I am using the data from https://de.wikipedia.org/wiki/ISO-3166-1-Kodierliste as this list contains the country names defined by the ISO 3166 standard. What I can do is maybe get rid of some stuff in parenthesis, if you think that's necessary. Also, note that the lists are created automatically by a script I made, so what we can do is to come up with rules to be applied to the German lists.

Or, even better, make the changes to the Wikipedia page if you think they are necessary...

oliver-la commented 6 years ago

Thanks for your feedback and your time.

The ISO 3166 standard covers country codes. The country names however, are not covered by this standard. [1]

ISO 3166 has three parts: codes for countries, codes for subdivisions and formerly used codes (codes that were once used to describe countries but are no longer in use).

You're using the short form of the country names in English, so why not do this for German (and probably other languages) too?

The reference I posted above [2] contains a full list of the short & long names, and the codes from the ISO-standard in uppercase. Do you think you can easily change your script to use this list [2] instead?

The issue with long names is that they're hardly ever used in daily communication. Switzerland, for example, is in your list called "Schweiz (Confoederatio Helvetica)". There's only one Switzerland/Schweiz, so there's no need to specify it further as Confoederatio Helvetica. And it's an outdated/wrong term anyway, the correct one would be Schweizerische Eid­genossen­schaft.

Also, I wouldn't strip out the parentheses of the list you're currently using. Taiwan is listed in your list as "Republik China (Taiwan)". As you can see this will not work out well.

stefangabos commented 6 years ago

Fair point about the ISO 3166 not covering country names! I suppose I could update my script to use your list for country names and the matching to be done via the ISO-3 and/or ISO-2. Should I use the "Staat" column or the "Langform des Staatsnamens" column?

oliver-la commented 6 years ago

That'd be awesome!

"Staat" would be the short name, so go for that one. (you'll need to leave out "ohne [...]".) The other column is the long name.

Or maybe it'd be easier to use this "cleaned up" version: https://laendercode.net/de/countries.html

I'll close this PR, since it's not going to be merged.

Thanks again.