stefangabos / world_countries

Constantly updated lists of world countries and their associated alpha-2, alpha-3 and numeric country codes as defined by the ISO 3166 standard, available in CSV, JSON , PHP, SQL and XML formats, in multiple languages and with national flags included; also available are the ISO 3166-2 codes of provinces/ states associated with the countries
http://stefangabos.github.io/world_countries/
Other
1.34k stars 374 forks source link

Language Requests (Croatian, Serbian, Slovene) #73

Closed AppyxDaniel closed 1 year ago

AppyxDaniel commented 1 year ago

Hi,

is it possible to add the following languages?

If not, what would need to be done in order to add those languages?

Thanks in advance!

stefangabos commented 1 year ago

For Croatian I'll have to update my script first as it currently expects tables. I'll update it so that it can also read lists like that. Afterwards I will be able to tell if something is missing or not.

The following are missing for Serbian

Bonaire, Sint Eustatius and Saba, bq, 535, bes
Curaçao, cw, 531, cuw
Saint Barthélemy, bl, 652, blm
Saint Martin (French part), mf, 663, maf
Sint Maarten (Dutch part), sx, 534, sxm
South Sudan, ss, 728, ssd
Sudan, sd, 729, sdn]

For Slovene, the following are missing

Bonaire, Sint Eustatius and Saba, bq, 535, bes
Curaçao, cw, 531, cuw
Guernsey, gg, 831, ggy
Isle of Man, im, 833, imn
Jersey, je, 832, jey
Montenegro, me, 499, mne
Saint Barthélemy, bl, 652, blm
Saint Martin (French part), mf, 663, maf
Serbia, rs, 688, srb
Sint Maarten (Dutch part), sx, 534, sxm
Sudan, sd, 729, sdn

In all cases, note that there s Sudans

728 => array('id' => 728, 'alpha2' => 'ss', 'alpha3' => 'ssd', 'name' => 'South Sudan'),
729 => array('id' => 729, 'alpha2' => 'sd', 'alpha3' => 'sdn', 'name' => 'Sudan'),
AppyxDaniel commented 1 year ago

Updated the sources for Serbian and Slovene. Please check again.

stefangabos commented 1 year ago

I've checked and both look good! I'll add them over the weekend and will try to make time for updating my script so that we can check Croatian. Thanks a lot for you work!

stefangabos commented 1 year ago

I found one thing In Slovenian, the numeric code for Srbija needs to be 688 instead of 891

AppyxDaniel commented 1 year ago

Oh sorry, I did not double check for duplicate names. Srbija existed twice in this list: once with 891 (Serbia and Montenegro) and one with 688. Since Serbia and Montenegro are now two separate entries, I removed the 891

stefangabos commented 1 year ago

Thanks for the quick update, I added both languages and published a new release. I'll try to find time over the weekend for adding the Croatian language. Please drop me a comment if you don't hear from me over the weekend as I tend to forget :) I am managing a lot of open source projects, work and family :) Thanks again!

stefangabos commented 1 year ago

For Croatian

The following are missing

AX Åland Islands BQ Bonaire, Sint Eustatius and Saba CW Curaçao PS Palestine, State of BL Saint Barthélemy MF Saint Martin (French part) SX Sint Maarten (Dutch part) SS South Sudan

The following need to be removed

AN Nizozemski Antili TB Tibet

AppyxDaniel commented 1 year ago

Please check again. I updated the source.

stefangabos commented 1 year ago

I added Croatian and made a new release. Thanks a lot for you contributions!