stefangweichinger / ansible-rclone

ansible role for rclone :: https://galaxy.ansible.com/stefangweichinger/ansible_rclone
156 stars 56 forks source link

Decide when to run release to ansible galaxy #160

Open gamezftw opened 1 month ago

gamezftw commented 1 month ago

159 broke the release since syntax for tags-ignore was fixed...

When do we want to run release to ansible galaxy?

  1. When there is a push to main automatically?
  2. When new tag is created?
  3. Something else?
gamezftw commented 1 month ago

Currently fixed with a75ce3e83fbaf535365d62b7621df39251a22d39 to run when tag is created.

stefangweichinger commented 1 month ago

Merged some PRs and edited README ... for now it's enough changes for me right now ;-)

I think I could remove https://github.com/stefangweichinger/ansible-rclone/blob/main/.github/workflows/galaxy_release.yml ... that was only a draft somehow.

The release task is also related to https://github.com/stefangweichinger/ansible-rclone/issues/144 and the use of commitizen etc. / back then I was pointed at using that but never fully learned or understood it, to be honest.

Basically I think the release should be triggered by a new tag, right?

Small edits etc could stay on gh, for example changes in the README or so don't have to be a release in my opinion.

I think that's the current config, right?

gamezftw commented 1 month ago

Currently workflow will run when there is a push to (possibly) any branch or when a tag is created: Runs your workflow when you push a commit or tag, or when you create a repository from a template. from https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push I agree that it would be better to run it when tag is created, filter docs: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push pattern docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-branches-and-tags Here is the pr that should address this #161

I will take a look at semantic versioning issue a bit later.

stefangweichinger commented 1 month ago

Great, thanks. pls allow some delay in my replies this week ...

stefangweichinger commented 1 month ago

another action we might use in this context: https://github.com/marketplace/actions/github-tag