search

stefanha / git-publish

Prepare and store patch revisions as git tags
MIT License
133 stars 35 forks source link

Crash when choosing "[s] Select patches to send (default: all)" #49

Open libvirtmirror opened 6 years ago

libvirtmirror commented 6 years ago

I get a traceback when entering 's' in the menu:

$ git publish
Stopping so you can inspect the patch emails:
  cd /tmp/tmp06j47hq2

..snip...

[c] Edit Cc list in editor (save after edit)
[t] Edit To list in editor (save after edit)
[e] Edit patches in editor
[s] Select patches to send (default: all)
[p] Print final email headers (dry run)
[a] Send all
[q] Cancel (quit)
s
Traceback (most recent call last):
  File "/usr/bin/git-publish", line 814, in <module>
    sys.exit(main())
  File "/usr/bin/git-publish", line 780, in main
    options.override_cc)
  File "/usr/bin/git-publish", line 479, in inspect_menu
    listfile.write("\n".join(patches))
  File "/usr/lib64/python3.6/tempfile.py", line 483, in func_wrapper
    return func(*args, **kwargs)
TypeError: a bytes-like object is required, not 'str'
libvirtmirror commented 6 years ago

This was using git-publish-1.4.3-1.fc28.noarch

stefanha commented 6 years ago

Thanks for reporting this bug. It has been fixed: https://github.com/stefanha/git-publish/commit/f1ef29d5cb4d3ddf8c896f7e76226ac0eb26e324

A new release will be published in a few days.