search

stefanhaustein / TerminalImageViewer

Small C++ program to display images in a (modern) terminal using RGB ANSI codes and unicode block graphics characters
Other
1.56k stars 111 forks source link

The last lines of pixels are missing #25

Closed HybridDog closed 6 years ago

HybridDog commented 6 years ago

If I view the minetest mese texture upscaled by a factor of 8, the lowest pixels are missing:

mese (8x): default_mese

what tiv shows (and newlines put around it): mese_tiv

HybridDog commented 6 years ago

thanks.

hadisfr commented 6 years ago

I should notice that current version through away at most 3 columns from right and at most 7 rows from bottom, because it calculates color in each 4x8-pixel bucket. But for such images (128x128) and many other common size standard (4n x 8m) works correctly and shows the whole picture. In other cases, due to limitations of CLI, we should trim pictures, the current approach, or virtually add some other pixels with same color. By the the way, the exact picture won't be displayed.

HybridDog commented 6 years ago

Maybe you could add a setting to display each pixel for pictures with low resolution, such as 16x16.