search

stefanhendriks / Dune-II---The-Maker

A remake of the classic Dune 2 - The Building of a Dynasty (by Westwood Studios) with several enhancements. Like: higher screenresolutions, zooming, multiselect, skirmish play, etc.
https://www.dune2themaker.com
304 stars 27 forks source link

Feature/order of bootstrapping #488

Closed Mira-Chronos closed 2 years ago

Mira-Chronos commented 2 years ago

Yet, command line options take precedence over ini file options.

New options : screenWidth, screenHeight

New param in game.ini : Fullscreen

Improve wrong param : program stop

stefanhendriks commented 2 years ago

Thanks for this PR!

I could verify the params working, overriding the game.ini setting. Which is great.

I have added --help switch to print out available instructions. Also when unknown argument is passed, it will print out that argument.

A little feedback: when naming variables, try to have them start with m_, we're trying to get this in consistently. I've corrected this myself in this PR; just for future reference.

Other than that looks good to me. 👍

I think this is good for now.

Will merge when green.

Example when executing d2tm.exe --help: image

stefanhendriks commented 2 years ago

This PR is for #466