search

stefanhendriks / Dune-II---The-Maker

A remake of the classic Dune 2 - The Building of a Dynasty (by Westwood Studios) with several enhancements. Like: higher screenresolutions, zooming, multiselect, skirmish play, etc.
https://www.dune2themaker.com
302 stars 27 forks source link

Linux: launch campaign may crash program #492

Open Mira-Chronos opened 2 years ago

Mira-Chronos commented 2 years ago

Program crash. Here what say gdb

Capture d’écran_2022-02-27_21-37-19

stefanhendriks commented 2 years ago

looks like something with the ini file (scenario) that seems to be interpreted as garbage? A quick google brings me here: https://stackoverflow.com/questions/13830338/377-character-in-c

perhaps it has to do with something like that?

Mira-Chronos commented 2 years ago

D2TM was working last week.

Maybe it's a bug that was integrated by a commit?

stefanhendriks commented 2 years ago

In that case you could use git bisect to trace down the commit that broke it?

Mira-Chronos commented 2 years ago

I discover git bisect !! Cool !!!

I discover something usefull for this issue First bad commit: bc3355181a1873e025d307797fcc1ab0bb20b872

Capture d’écran_2022-03-02_00-24-43

stefanhendriks commented 2 years ago

yeah git bisect is actually pretty neat huh? :D

stefanhendriks commented 2 years ago

although, I am unsure how that commit broke things. Considering your gdb dump it looks like as if it broke on ini.cpp, but the commit that broke it is not touching that?

Mira-Chronos commented 2 years ago

On https://github.com/stefanhendriks/Dune-II---The-Maker/pull/498 branch, this bug is gone.

800x600_0000

On https://github.com/stefanhendriks/Dune-II---The-Maker/pull/490 the bug is real.

I don't fix it. (it's not conscious!)

Just #458 is always there.

stefanhendriks commented 2 years ago

Is this still bugged? (on master)

Mira-Chronos commented 2 years ago

Yes. PR #498 the bug is gone.