stefanhendriks / Dune-II---The-Maker

A remake of the classic Dune 2 - The Building of a Dynasty (by Westwood Studios) with several enhancements. Like: higher screenresolutions, zooming, multiselect, skirmish play, etc.
https://www.dune2themaker.com
302 stars 27 forks source link

Chore/rewriting map #495

Closed Mira-Chronos closed 2 years ago

Mira-Chronos commented 2 years ago
stefanhendriks commented 2 years ago

build fails, because of reasons. Need to check that, after it is green again this can be merged.

AssociationSirius commented 2 years ago

I didn't have any error when i have work on this PR. I can't work on it because it's on Windows-msys2

mnhauke commented 2 years ago

I didn't have any error when i have work on this PR. I can't work on it because it's on Windows-msys2

I can see the same compilation error on Linux with gcc 12.1. It seems related to some changes in gcc 12.x https://gcc.gnu.org/gcc-12/changes.html

-Waddress has been enhanced so that it now warns about, for instance, comparing the address of a nonstatic member function to null (PR102103)

AssociationSirius commented 2 years ago

My bad, my code, i will find a solution ...

AssociationSirius commented 2 years ago

I didn't have any error when i have work on this PR. I can't work on it because it's on Windows-msys2

I can see the same compilation error on Linux with gcc 12.1. It seems related to some changes in gcc 12.x https://gcc.gnu.org/gcc-12/changes.html

-Waddress has been enhanced so that it now warns about, for instance, comparing the address of a nonstatic member function to null (PR102103)

Thx !

stefanhendriks commented 2 years ago

I could reproduce it with gcc12 as well (msys2 on windows); made a small change and pushed it - it should compile now.