search

stefanhk31 / personal_blog_flutter

https://stefanhodgeskluck.com
2 stars 0 forks source link

Make Butter logo in Footer clickable #40

Closed stefanhk31 closed 8 months ago

stefanhk31 commented 8 months ago

Needed for dev subscription

stefanhk31 commented 8 months ago

Test failing, probably needs correct path to load asset bundle

stefanhk31 commented 8 months ago

Possibly also need to runAsync and/or cache image?

https://github.com/flutter/flutter/issues/38997

stefanhk31 commented 8 months ago

Could POSSIBLY make a Leading and OnLeadingTap property on footer and test with a sized box...but not ideal, will make the widget more complex

stefanhk31 commented 8 months ago

Ok, apparently this is more stubborn... need to try running test on simulator to see layout?

stefanhk31 commented 8 months ago

Might also be worth setting static height on image asset to see if that sizes it to be clickable

stefanhk31 commented 8 months ago

Also, just a thought... could make a FooterLogo widget that takes URL launcher and bypasses need for a bloc. Still have to deal with testing an image but... maybe better than adding AppBloc just for this?

stefanhk31 commented 8 months ago

Maybe also do this without an app bloc if url launcher is in repo? Or at least replace with cubit?

stefanhk31 commented 8 months ago

I think maybe refactor into GD surrounding just image. Can even try to make a dedicated widget in same file to see if it's tappable in a test case isolated from footer.