This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint-plugin-node.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
c289f18 added no-hide-core-modules rule.
This rule disallows require() expressions and import declarations if those import a third-party module which has the same name as core modules. Especially, if you depend on such modules indirectly and npm flattens dependencies, you can depend on such third-party modules before as you know it. This might cause unintentional behaviors.
17c8ae0 fixed the behavior of no-deprecated-api rule about indirect dependencies. The no-deprecated-api rule has ignored deprecated APIs if a code imports the third-party module which has same name as a core module. However, I found it can cause confusing because of indirect dependencies and flatting dependencies.
Now, The no-deprecated-api rule does not ignore deprecated APIs even if a code imports the third-party module which has same name as a core module except it's in your package.json explicitly.
If you want to revive old behavior, please set ignoreIndirectDependencies: true option.
With Integrationsfirst-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.
Screencast Try it today. Free for private repositories during beta.
Coverage remained the same at 100.0% when pulling 9fa6500c87e10ae64dff3a2183c2f1eceab66ed1 on greenkeeper-eslint-plugin-node-4.1.0 into a73f00e6ac119869267951e41b8d46d97feeb849 on master.
Hello lovely humans,
eslint-plugin-node just published its new version 4.1.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint-plugin-node. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project :sparkles:
You rock!
:palm_tree:
GitHub Release
New rules
This rule disallows
require()
expressions andimport
declarations if those import a third-party module which has the same name as core modules. Especially, if you depend on such modules indirectly andnpm
flattens dependencies, you can depend on such third-party modules before as you know it. This might cause unintentional behaviors.Enhancements
Bug fixes
Now, The no-deprecated-api rule does not ignore deprecated APIs even if a code imports the third-party module which has same name as a core module except it's in your
package.json
explicitly.If you want to revive old behavior, please set
ignoreIndirectDependencies: true
option.The new version differs by 38 commits .
3f03d92
4.1.0
c289f18
New: no-hide-core-modules (fixes #66)
16973f9
Chore: hide a complexity warning.
17c8ae0
Update: fix no-deprecated-api about modules which are hiding core modules (fixes #65)
91ebdf4
Update: update no-unsupported-features for Node 7.6 supports async/await (fixes #67)
1c12cae
4.0.1
2991302
Fix: New Buffer APIs are available in 4.5.0 (#64)
5fdb19a
4.0.0
6172870
Update: add ignore options to
no-deprecated-api
(fixes #58)fb485af
Chore: use new rule format
f8a5e0b
Update: add "excluding files" feature to convertPath option (fixes #60)
390c9ec
Chore: simpify tests for es modules
719fb4d
Chore: rename .eslintrc → .eslintrc.json
ecb7c49
Breaking: drop supports for ESLint 2
ba283df
Breaking: drop supports for Node 0.x
There are 38 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.