search

stefanjudis / credits

Find out on whose work your project is based on
MIT License
10 stars 18 forks source link

Refactor files #92

Closed Hypercubed closed 8 years ago

Hypercubed commented 8 years ago

This is a refactor of the source files but no functional changes.

1) All tests are based in static fixtures rather than generated. 2) Tests and fixtures are located in the test directory. 3) test directory is not included in published package.

Hypercubed commented 8 years ago

Since this is a big change I'd like to get an LGTM from @stefanjudis .

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.6%) to 95.946% when pulling 55b81935573bbd628737e4a9f0ff276093a7e03c on Hypercubed:refactor into 439f3055570975fba549912575472e0148b00df8 on stefanjudis:master.

Hypercubed commented 8 years ago

Sorry about the noise on this... had some trouble getting the CI to pass.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.6%) to 95.946% when pulling 918d627b0e52ab4b171eba2bc78f2b5dcd2d0865 on Hypercubed:refactor into 439f3055570975fba549912575472e0148b00df8 on stefanjudis:master.

Hypercubed commented 8 years ago

I think this is ready to merge. After this I think I'm going to replace the manual searching with globbing.

stefanjudis commented 8 years ago

After this I think I'm going to replace the manual searching with globbing

👍

Tests and fixtures are located in the test directory.

Looks solid to me! 🎉

Why did the test coverage decrease?

Hypercubed commented 8 years ago

Not sure why coverage decreased. I'll look into it.