Please consider the following

stefanjudis / credits

Find out on whose work your project is based on

MIT License

10 stars 18 forks source link

Please consider the following #96

Open Hypercubed opened 8 years ago

Hypercubed commented 8 years ago

A few suggestions I think we can consider:

[x] Use eslint-plugin-node to ensure post node v4 features are not accidentally added. (see #97)
[ ] Get the package name from the name attribute instead of the folder name. (see wip)
[ ] Each analyzer should return a promise. (see wip)
[x] Migrate from eslint with custom rules to xo.
[ ] Migrate from ava to jest. (For snapshot feature).
[ ] Support component.json

adam-golab commented 6 years ago

I started working on a migration from ava to jest

stefanjudis commented 6 years ago

@adam-golab

Thanks for doing that! 🎉

May I ask what the benefits are in this case over Ava? I haven't worked with Jest yet but know it's great for snapshot testing in react. Does this apply here?

Side note: I don't think I have time to maintain this repo anymore. Happy to give you access if you want to contribute. :)

adam-golab commented 6 years ago

Jest has a lot more features built-in. So, there is no need for adding any plugins. I really like jest's mocking functionality. You can mock almost anything and test only what's needed.

Regarding snapshot testing, it's great, but currently, ava has this feature as well in the newest version. It works very well with React components as well as with just regular JS types. So, if you want to migrate only for snapshot testing I think it will be better to just update ava :)