search

stefanjudis / grunt-phantomas

Grunt plugin wrapping phantomas to measure frontend performance
MIT License
285 stars 25 forks source link

custom html templates #133

Closed kisin closed 9 years ago

kisin commented 10 years ago

it would be great if you add the option to build custom html, so we could improve the ui look and feel.

stefanjudis commented 10 years ago

@kisin Hey,

okay, that's not a problem at all. But I'm not sure when I'll make it - maybe want to propose a PR? :bowtie:

But may I ask what kind of ui improvements you're talking about?

kisin commented 10 years ago

i want to build my own dashboard to display the data for my company site.

beautify the results and put them in a beautiful dashboard like this for example: https://dribbble.com/shots/1315388-Dashboard-Web-App-Product-UI-Job-Summary/attachments/184703

stefanjudis commented 10 years ago

@kisin

Okay, got your point.

But that's completely different. Sure the option for custom HTML/JS/CSS can be implemented, but in my mind it's way too much, because you want to build your own thing.

I'd rather build a tool that totally fits your needs. And fetching the data with phantomas is really not complicated.

But as said, sure it can be implemented, but I wouldn't go this way with grunt-phantomas. :bowtie:

kisin commented 10 years ago

i love your grunt plugin and the possibilities it gives in monitoring front end performance. but, what can i say, i think the UI you choose to display the results is not good and not showing the real data over time.

i want my front end developers to look on the dashboard and immediately recognize issues to fix.

can you guide me how to manipulate the html to my needs?

stefanjudis commented 10 years ago

Fair enough. Thanks for feedback.

If you could define detailed improvements and points you don't like, we can discuss if it may be implemented in this project. I more than happy about proposed improvements and discussions about the UI.

not showing the real data over time.

I don't get this one, because this is exactly what it does.

And about how to change it completely - it's underscore templating and d3 scripting. Not much magic about it. Do you have any detailed questions about this?

And what you have to keep in mind is, that it is a static generated html page. Sure a webapp would be awesome, I totally agree with this, but that's really not an easy task without any serverside component.

stefanjudis commented 10 years ago

@kisin ping. :)

stefanjudis commented 9 years ago

@kisin I'm closing this one. Feel free to reopen if needed.