search

stefanjudis / grunt-phantomas

Grunt plugin wrapping phantomas to measure frontend performance
MIT License
285 stars 25 forks source link

Maximum Assertions? #139

Closed nikmd23 closed 9 years ago

nikmd23 commented 9 years ago

From readme.md:

The UI will warn you whenever the median value of your defined runs of a specific metric will go over the specified value...

I have a scenario where I only want to be warned if a value goes under the specified value.

For example: phantomas

I screwed up my web server config and wasn't serving compressed assets. Now I am and want to make sure I don't mess it up again, so I set an assertion. Unfortunately, assertions only work in one direction.

How do I indication I want a warning if I have less than two compressed assets?

stefanjudis commented 9 years ago

@nikmd23 Hmm... Interesting. :)

Yeah might be possible quickly. Unfortunately I'm quite busy until next week.

Maybe you're interested in contributing, then I could point you in the right direction? :)

If not no problem. :)

nikmd23 commented 9 years ago

No worries.

I'm also slammed with Thanksgiving (:us:) and prepping for a presentation at a big conference the following week. I'm going to be demoing grunt-phantomas in that presentation, but I'll just avoid this use case and show off everything else that can be done. :wink:

stefanjudis commented 9 years ago

Okay, now you got me. :)

When will you do the demo? And may I ask which conference? It might be done until then. ;)

nikmd23 commented 9 years ago

Haha. That certainly wasn't my intent!

I'd need the demo to be ready by the 3rd of December. ;)

stefanjudis commented 9 years ago

Okay - let's do it. ;)

Can you maybe ping me in one week, when it's not done yet? I'll planning to ship next minor version before 3rd of December then. :)

nikmd23 commented 9 years ago

Sure thing, sounds good to me. :wink:

stefanjudis commented 9 years ago

screenshot 2014-11-29 23 14 32

I'd go with this - if it's fine. :)