search

stefanjudis / grunt-photobox

Grunt plugin for creating screenshots of any site and compare them
MIT License
277 stars 22 forks source link

Diff not detected with template: canvas when having transparency in img #23

Closed danez closed 10 years ago

danez commented 10 years ago

The diff is not highlighted when last img has transparency.

new secure-staging kyto com-login-1200

current: secure-staging kyto com-login-1200

Tested with dev-master

stefanjudis commented 10 years ago

@chaeringer maybe wanne have a look when time?

stefanjudis commented 10 years ago

I think it's the same as this issue here:

Not working diff

White and red are not marked blue showing it's a difference.

danez commented 10 years ago

maybe see http://phantomjs.org/faq.html. last question there.

stefanjudis commented 10 years ago

Jap, true. :)

But I'd say that each site should just set a give background color. But anyway, there is another issue with the diff generation, when the background is white/transparent.

stefanjudis commented 10 years ago

bildschirmfoto 2014-02-11 um 11 57 15

stefanjudis commented 10 years ago

@chaeringer could you check last commit?

stefanjudis commented 10 years ago

Shipped with 0.8.0.