search

stefanjudis / grunt-photobox

Grunt plugin for creating screenshots of any site and compare them
MIT License
276 stars 22 forks source link

Split photobox to another library #26

Open paazmaya opened 10 years ago

paazmaya commented 10 years ago

I would like to use the methods available in tasks/lib/photobox.js and import it as it is now used via tasks/photobox.js Grunt task.

Any plans on separating the two, perhaps as node-photobox and grunt-photobox, essentially having the non Grunt parts in the first?

stefanjudis commented 10 years ago

Hmm. Haven't thought about that yet. But that's basically a really good idea! It's already quite heavy for a task. :)

But can not promise, when that will happen. :(

I'm planning a complete rewrite in future, so that this would be a part of it. Maybe you want to support with that? I mean first step is basically just copy & paste, right?

stefanjudis commented 10 years ago

Let's wait for 0.7.2 to be done and then I could start with that. Or do you need it urgently?

paazmaya commented 10 years ago

Great to hear you agree.

Yes, initially just copy & paste and replace Grunt related methods with plain Node.js counterparts.

davidlinse commented 9 years ago

Hi, any news on this ?

stefanjudis commented 9 years ago

Mmm, not really. Wanna jump in?

I've got no real time for this repo in near future. So I'm more than happy to give collab rights to everybody who wants to.

paazmaya commented 9 years ago

Perhaps Photobox could be changed so that it would created the front end as it does now, but the image comparison is done via https://www.npmjs.com/package/shigehachi (which also has a Grunt task)

stefanjudis commented 9 years ago

@paazmaya I'm totally up for this.

Can you please open a new issue? This issue was about removing the grunt dependency. :)

paazmaya commented 9 years ago

Yes.