stefanjudis / grunt-photobox

Grunt plugin for creating screenshots of any site and compare them
MIT License
277 stars 22 forks source link

Add possibility to have just relative urls in image names #33

Closed danielhusar closed 9 years ago

danielhusar commented 9 years ago

Hi I think its a good idea, as this allow you to compare some local url like http://localhost:3000 with some live urls :)

@stefanjudis what you think about this?

stefanjudis commented 9 years ago

@danielhusar Oh man, something like this is on my todo list for a really long time already.

I'll try to check it on the weekend. :) If not feel free to ping me again.

Thanks a lot for the effort. :bowtie:

danielhusar commented 9 years ago

Cool, thanks :)

danielhusar commented 9 years ago

Hey, any chance to look on it yet ? :)

stefanjudis commented 9 years ago

Aaaah great reminder. ;)

Not really, sorry. But I don't mind merging it. :)

You agreed to become a maintainer, right?

No need also for working in your fork - you can directly branch in this repo.

stefanjudis commented 9 years ago

Just had a super quick look. :)

Can you extend readme a bit more and stick to coding style ( spaces ) on several places. I'll try to make functional check asap.

But as said - I've got no problem to merge and publish. If you say 'GO', we push it out. :)

Thanks a lot for taking time and your contribution. :)

danielhusar commented 9 years ago

Hey yeah cool, will add some more examples tomorrow, thanks for quick look ! :)

danielhusar commented 9 years ago

@stefanjudis I have polished spacings a little, hopefully its better now :) and added some sample config to readme. (I know the described usage scenario there is not perfect, but this way you can very easily compare two version of same page, but maybe we should introduce something like base urls and generate screens for all urls and then generate index.html ? )

danielhusar commented 9 years ago

Hey :) So I have tested it yesterday for quite long and it looks like all is working fine, so I can merge it now, and you can publish new version when you have some time :)

danielhusar commented 9 years ago

Also, what you think about moving to something more robust to generate images like pageres ?

stefanjudis commented 9 years ago

@danielhusar nothing against pageres! If you want to put it in, go ahead. :)