search

stefanjudis / grunt-photobox

Grunt plugin for creating screenshots of any site and compare them
MIT License
276 stars 22 forks source link

Add ability to filter images #34

Closed danielhusar closed 8 years ago

danielhusar commented 9 years ago

Hey, I have added ability to show only modified screenshots :) Currently it works only for canvas, as image magic is little more complicated (maybe crate some json with changes there ?)

This is how it looks like: screen shot 2015-01-20 at 11 58 48

Partially fixes: #32

@stefanjudis what you think ?

stefanjudis commented 9 years ago

Loving it. :)

But would also only go with it, when it's supported for all options. As far as I know imagemagick can also evaluate number of different pixels and stuff. :)

Please think of the spaces coding-style. :) Sorry, but consistent style is really important to me. :bowtie:

danielhusar commented 9 years ago

Ah sorry, I usually don't pay attention to spaces/tabs as editor config solve this, will fix it.

Ok I will try to came with something for the image magic as well.

stefanjudis commented 9 years ago

Great!

yeah - editor config is not looking for spaces regarding coding style isn't it? JSCS is a nice thing, I've got included in different projects.

We might also think of putting it in here.

Thanks. :)

stefanjudis commented 9 years ago

@danielhusar

Do we want to finish this one day? No pressure, but if not I'll close the PR.

danielhusar commented 9 years ago

Hey,

Yeah I hope so :) I'm usually quite busy at my job but I will try to do it next time I have some time off :)

stefanjudis commented 9 years ago

Ja, no pressure. :)

Just wanted to check, because I also have rarely time.

stefanjudis commented 8 years ago

Closing due to inactivity.

sbmadhav commented 8 years ago

was this merged to master ? How to configure threshold ?

stefanjudis commented 8 years ago

@sbmadhav Nope - was not finished due to inactivity. Sorry.

sbmadhav commented 8 years ago

Let me see if I can contribute to this. No commitments yet. But this is something I need.