search

stefanjudis / grunt-photobox

Grunt plugin for creating screenshots of any site and compare them
MIT License
276 stars 22 forks source link

Screenshots do not show all elements #35

Closed dmorda closed 7 years ago

dmorda commented 9 years ago

Hi Stefan,

I love photobox and it works in 9 out of 10 cases for me. However, there are a few pages that may take a few milliseconds longer to load because they are doing javascript'ish things with photos such as using Foundation's Interchange. As a result, those photos are not displayed in the output files consistently.

Would there be a way to include a "delay" option that tells the task how long to wait for the page to load before taking the screenshot?

stefanjudis commented 9 years ago

@dmorda

Whooops - I kind of missed this one. Sorry for that. :(

Sure thing.

Shouldn't also be a big deal.

The place to tackle might be:

https://github.com/stefanjudis/grunt-photobox/blob/master/tasks/lib/photoboxScript.js#L78

I'm not sure, when I'm available for that, but I'd gladly look over a PR. :)

sbmadhav commented 8 years ago

@dmorda , @stefanjudis : i hope pull request #44 closes out this issue.