search

stefanjudis / grunt-photobox

Grunt plugin for creating screenshots of any site and compare them
MIT License
276 stars 22 forks source link

Added timeOut Option #38

Closed mattimatti closed 9 years ago

mattimatti commented 9 years ago

Hello I've added a timeOut option as you suggested in #35. Thank you!

stefanjudis commented 9 years ago

Thanks will have a quick look soon. :)

stefanjudis commented 9 years ago

@mattimatti Test suite is failing. Can you have a look?

mattimatti commented 9 years ago

hello Stefan I've updated the test case. Introducing the hashbang handling I've changed the URL#QUALITY format to URL@QUALITY format. I assume it doesn't create problems out of the box. as this url naming is supposed to be internal. Feel free to reject and discuss better solution.

stefanjudis commented 9 years ago

@mattimatti

Hey hey,

thanks for putting the effort into.

I checkout out the PR and it doesn't seem to work. UI is broken and the generated images seem to have wrong file names.

screenshot 2015-04-13 20 38 49 screenshot 2015-04-13 20 39 17

stefanjudis commented 9 years ago

@mattimatti

Any news on this one?

stefanjudis commented 9 years ago

@mattimatti

Ping again. :)

I think I'm gonna close this one soon'ish, if no there is no response anymore.

sbmadhav commented 8 years ago

I think I can contribute to this. I'll need this anyway.

stefanjudis commented 8 years ago

If you're up for it I also can give you access. I'm not using this project anymore and would love to have someone bringing it further. :)

sbmadhav commented 8 years ago

Sad that you are not using it anymore. Its a great peice of work. Some more tweaks and it should be able to compete with the likes of huxley/ phantom css or wraith. Sure, I can own it.