search

stefanjudis / grunt-photobox

Grunt plugin for creating screenshots of any site and compare them
MIT License
277 stars 22 forks source link

Error list #40

Closed fonzerelly closed 8 years ago

fonzerelly commented 9 years ago

Hi Stefan,

since I was not clear, weather you would like the additional change I did for your great photobox-project, I put it into a separate pull request, so that you at least can take over the bugfix, if you don't like my idiea.

I wanted to get a better overview, which screens taken by photobox differ. In my usecase, I will have to track several douzens of screens to check if a css-factoring breaks the rest. So I appended ids to each image, with which I now build up a link list of all screens that differ and I am able to examine them right by following that link.

I am not quite a css guy, so my design for the error list might be a bit poor. I would love to get proposals for improvement from you.

So if you would take this pull request in to account, would it be intereseting for you, If I would realize such an error list also for the magic-template and not only for canvas-template as I currently do?j

Thanks for your help Fonzy

stefanjudis commented 9 years ago

@fonzerelly

Thanks a lot for you interest in this project.

Can you provide a screenshot, of what this PR is doing to the generated FE?

If you're interested in pushing more, I've got also no problem to give you complete access. :blush:

fonzerelly commented 9 years ago

errorlist Hi Stefan,

sorry have a lot to do right now... Here is a screenshot of my photobox-version with the error list. As you can see at the top, there is a list of links to only those screenshots that diffs. So do you think, this would be interesting for the imagemagic version too?

stefanjudis commented 9 years ago

Totally!!! :tada:

stefanjudis commented 8 years ago

Closing due to inactivity.