Use custom openssl command

stefanjudis / is-http2

Module to check for http/2 support

MIT License

14 stars 4 forks source link

Use custom openssl command #85

Closed StephanGeorg closed 6 years ago

StephanGeorg commented 7 years ago

Its hard to update openssl in macos. Would be easier to overwrite default openssl command with a custom one i.e. from Homebrew:

isHttp2(url, { 
  includeSpdy: true,
  openssl: '/usr/local/Cellar/openssl/1.0.2k/bin/openssl'
})

coveralls commented 7 years ago

Coverage increased (+0.08%) to 93.671% when pulling b99371aaf28a053f91c3b1bcbbf31797cb84ec14 on StephanGeorg:master into 817ce986af0ff1ca9c4bc56aa1fd4528afbdcb3d on stefanjudis:master.

stefanjudis commented 6 years ago

Oh well... so sorry I didn't see that PR here. :(

Still wanna bring it in? If so could you add the new options property to the readme? :)

coveralls commented 6 years ago

Coverage increased (+0.08%) to 93.671% when pulling d5dfa21eef58ba5ad02d157c666bd1bb63440c56 on StephanGeorg:master into 817ce986af0ff1ca9c4bc56aa1fd4528afbdcb3d on stefanjudis:master.

coveralls commented 6 years ago

Coverage increased (+0.08%) to 93.671% when pulling d5dfa21eef58ba5ad02d157c666bd1bb63440c56 on StephanGeorg:master into 817ce986af0ff1ca9c4bc56aa1fd4528afbdcb3d on stefanjudis:master.

coveralls commented 6 years ago

Coverage increased (+0.08%) to 93.671% when pulling d5dfa21eef58ba5ad02d157c666bd1bb63440c56 on StephanGeorg:master into 817ce986af0ff1ca9c4bc56aa1fd4528afbdcb3d on stefanjudis:master.

StephanGeorg commented 6 years ago

Yes, updated readme and also bump version.

Best Stephan and merry 🎄

coveralls commented 6 years ago

Coverage increased (+0.08%) to 93.671% when pulling d5dfa21eef58ba5ad02d157c666bd1bb63440c56 on StephanGeorg:master into 817ce986af0ff1ca9c4bc56aa1fd4528afbdcb3d on stefanjudis:master.

stefanjudis commented 6 years ago

Whoop whoop! Looks good now. :) Thanks. :)

stefanjudis commented 6 years ago

And published. 🎉