stefanjudis / tiny-helpers

A collection of useful online web development tools
https://tiny-helpers.dev
MIT License
954 stars 319 forks source link

Add Image BG Blurer #517

Closed denno020 closed 8 months ago

denno020 commented 8 months ago

Thank you for opening a pull request to tiny-helpers.dev ❤️

Before you submit your PR, please take a look at the contributing guidelines. :)

To make it easier for us to review and merge your PR, please make sure …

Thank you! 🙇‍♂️

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tiny-helpers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 0:25am
stefanjudis commented 8 months ago

@denno020 Thanks for contributing to TH.

I just tried it but it didn't seem to work in FF or Chrome. The downloaded images wasn't blurred or anything after downloading it. :/

grafik
denno020 commented 8 months ago

That's odd, I was using it heaps today..

Does that image have a transparent background? Or is it all white? If it's all white, and if it's the same aspect ratio as the preview, then the actual image is likely blocking the blur

On Fri, Feb 23, 2024, 18:21 Stefan Judis @.***> wrote:

@denno020 https://github.com/denno020 Thanks for contributing to TH.

I just tried it but it didn't seem to work in FF or Chrome. The downloaded images wasn't blurred or anything. :/ grafik.png (view on web) https://github.com/stefanjudis/tiny-helpers/assets/962099/0dd3cde8-5dd9-42e2-b780-4a69bdebe3d5

— Reply to this email directly, view it on GitHub https://github.com/stefanjudis/tiny-helpers/pull/517#issuecomment-1960870807, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPWYMJIQ65UL46X46HVA7DYVBDABAVCNFSM6AAAAABDV4BZO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQHA3TAOBQG4 . You are receiving this because you were mentioned.Message ID: @.***>

stefanjudis commented 8 months ago

Here's the image. :)

Screenshot 2024-02-19 at 04 10 12

denno020 commented 8 months ago

Okay great. Did you download that image from the tool? The name of it makes me think that it came from the app, but there definitely isn't any blurring..

I've run that image through removebg.com, and then uploaded it back into Image BG Blurer, and we can see that there is some blurring, but the blurred image isn't covering the preview window as it should be.

I then realised that removebg.com will make the background transparent, it doesn't crop the image. So Image BG Blurer is seeing an image that is the exact aspect ratio/size of the preview window, so it doesn't attempt to scale up, because the image is already touching the edges.

So I cropped your original image tightly around the graphic, and re-uploaded it, and now that's working as we would like :)

On Fri, 23 Feb 2024 at 19:11, Stefan Judis @.***> wrote:

Here's the image. :)

notion-image.png (view on web) https://github.com/stefanjudis/tiny-helpers/assets/962099/fffffa7c-6b2b-4e03-b2d5-ebf21ca88973

— Reply to this email directly, view it on GitHub https://github.com/stefanjudis/tiny-helpers/pull/517#issuecomment-1960928322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPWYMOZJEYZDVMBXBCJ2TTYVBI3FAVCNFSM6AAAAABDV4BZO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQHEZDQMZSGI . You are receiving this because you were mentioned.Message ID: @.***>

denno020 commented 8 months ago

I replied to the email and unfortunately the images that I attached to that email didn't come through with my message..

Here they are now:

307264269-fffffa7c-6b2b-4e03-b2d5-ebf21ca88973-removebg-preview cropped 95f1c68d-29e4-449f-a2e6-df3e3b87d617

stefanjudis commented 8 months ago

Alright. I think I see what's going on. I just tried another image.

grafik

I kinda works but I think it's hard to use. Could we add an easy way to add vertical / horizontal padding to the image? I would expect people will be as confused as I am.

So I'd propose upload an image and to sliders that allow me to see the outer spacing which will include the blurred effect.

WDYT? :)

denno020 commented 8 months ago

Thanks for the feedback mate! There is an aspect ratio button in the top right of each preview that can be used to change the dimensions of the image that is generated, which I believe will achieve the same outcome as having sliders.

I'm pretty happy with the UI as it is. It's certainly not the prettiest, but I've found it to be pretty functional and haven't actually had anyone indicating they're getting confused, so keen to keep it as is.

If that's a blocker for Tiny Helpers, then I thank you for considering my little app for your directory :)

stefanjudis commented 8 months ago

Alright. Then thanks for considering TH. :)

I've to be a little more gate keeper'ish these days and I think I'm gonna pass for now.

Thanks for understanding. :)