search

stefankendall / Big-Lifts-2

Native is better. Big Lifts 2 for iOS
bigliftsapp.com
2 stars 0 forks source link

Automatically rounds to whole numbers despite being set to 0,5 #10

Open rDivaDuck opened 9 years ago

rDivaDuck commented 9 years ago

When set to kgs in unit, it always rounds up, preventing you from having 0.5kg bar weights which gets rounded to 0kg, or a 42.5kg bench press which gets rounded to 42kg

stefankendall commented 9 years ago

What are your exact plate setups in Menu > Bar Loading? What is the max/training max causing issue? What week of what plan?

If I can setup the exact data scenario and reproduce the issue I can fix it. It looks to me like it's rounding right, but if I setup your exact data I can learn more.

[image: Inline image 1]

On Sun, Jun 14, 2015 at 2:59 PM, rDivaDuck notifications@github.com wrote:

When set to kgs in unit, it always rounds up, preventing you from having 0.5kg bar weights which gets rounded to 0kg, or a 42.5kg bench press which gets rounded to 42kg

— Reply to this email directly or view it on GitHub https://github.com/stefankendall/Big-Lifts-2/issues/10.

rDivaDuck commented 9 years ago

Ive uploaded an imgur album with the relevant pictures, in all counts ive tried to add the 0,5kg and its been rounded to a whole, ie 42.5 to 42kg, 2.5kg increments to 2kg increments.

another related issue is the fact that you cant add 1.25kg weights to the bar loading, which is a very common metric weight plate

http://imgur.com/a/bTv2G

stefankendall commented 9 years ago

I see that the plate looks like "0kg" instead of 0.25. What happens when you try and use 1,25, with a positive plate count and hit save?

I'm seeing 1.25 getting added to the app.

On Sun, Jun 14, 2015 at 5:38 PM, rDivaDuck notifications@github.com wrote:

Ive uploaded an imgur album with the relevant pictures, in all counts ive tried to add the 0,5kg and its been rounded to a whole, ie 42.5 to 42kg, 2.5kg increments to 2kg increments.

another related issue is the fact that you cant add 1.25kg weights to the bar loading, which is a very common metric weight plate

http://imgur.com/a/bTv2G

— Reply to this email directly or view it on GitHub https://github.com/stefankendall/Big-Lifts-2/issues/10#issuecomment-111877714 .

rDivaDuck commented 9 years ago

I found the issue, i was being presented with a numerical keyboard where the decimal separator was punctuation mark, and after switching the keyboard to a comma, it accepted it just fine.

Perhaps making it accept both could remove some confusion?