search

stefankoegl / python-json-pointer

Resolve JSON Pointers in Python
https://python-json-pointer.readthedocs.org/
Other
140 stars 43 forks source link

Update to python 3.7 #52

Closed sweeneytr closed 3 weeks ago

sweeneytr commented 1 year ago

Versions prior to 3.7 are EoL, and the lack of access to from __future__ import annotations in <=3.6 make it not worth working around.

Pypi stats shows there is still some 3.6 utilization, but as breaking 2.7 support is typically handled by a major version bump, and going from 3.6 -> 3.7 is trivial, the regular maintaince of "a major bump happened" should be enough for them to push to 3.7.

sweeneytr commented 1 year ago

This would resolve https://github.com/stefankoegl/python-json-pointer/issues/48

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6b50420ace347da0f240a04054c83b950545d89d on sweeneytr:master into a95c26fba8ef44af6d16ad6c5b70d7f9c69ae36c on stefankoegl:master.

sweeneytr commented 1 year ago

was fun fighting Travis. Anyhow, sorry for the mangled work, I applied black as an auto-formatter and it made the diff larger than I'd like, but I can't really put the genie back in it's bottle there. Will just leave it as is until complaints.

stefankoegl commented 1 year ago

Thanks for the great work! If we drop <= 3.7 here, this will break stefankoegl/python-json-patch. Would you be up for looking into that as well?

sweeneytr commented 1 year ago

Yes, I am all for it! I'll link it when done.

On Mon, Dec 12, 2022, 14:59 Stefan Kögl @.***> wrote:

Thanks for the great work! If we drop <= 3.7 here, this will break stefankoegl/python-json-patch. Would you be up for looking into that as well?

— Reply to this email directly, view it on GitHub https://github.com/stefankoegl/python-json-pointer/pull/52#issuecomment-1347214352, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDQ7E6MIMSISZRQNABQ7BLWM573BANCNFSM6AAAAAASQBNZAA . You are receiving this because you authored the thread.Message ID: @.***>