search

stefankroes / ancestry

Organise ActiveRecord model into a tree structure
MIT License
3.74k stars 462 forks source link

[work in progress] drop active record five two #538

Closed d-m-u closed 3 years ago

d-m-u commented 3 years ago

hi, I think we also want to do this sometime.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 98.063% when pulling 98ca70789c65887b430346412682141cdd7c60fa on d-m-u:drop_5_2 into 2ff497e3d696a3a99ecdf5177afa18ec4cf0d707 on stefankroes:master.

kbrock commented 3 years ago

5.2 supports ruby 2.2 - it still is under security release and has a little life left in it. I suppose we could say that 5.2 is still supported in the non-head. That would allow us to drop a few of the monkey patches we needed. Think most of the monkey patches were for 5.1

kbrock commented 3 years ago

oh dear - per https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html

looks like ruby 2.5 is the common denominator for these.