change the valid check to not only run on the entire object

stefankroes / ancestry

Organise ActiveRecord model into a tree structure

MIT License

3.72k stars 459 forks source link

change the valid check to not only run on the entire object #542

Closed d-m-u closed 3 years ago

d-m-u commented 3 years ago

Per https://github.com/ManageIQ/manageiq/pull/21226#discussion_r636137634

coveralls commented 3 years ago

Coverage remained the same at 98.068% when pulling 824e8e6464a72a5726ea922b972f5ecec74a9428 on d-m-u:fix_sanity into 0a1337e41e594357803ca76466593afe86b62ba1 on stefankroes:master.

kbrock commented 3 years ago

kicking

kbrock commented 3 years ago

maybe you can add a test around updating a model with invalid data in it or something? not sure the best way to test this use case