reverting deprecating has_ancestry in subclasses

stefankroes / ancestry

Organise ActiveRecord model into a tree structure

MIT License

3.72k stars 458 forks source link

reverting deprecating has_ancestry in subclasses #629

Closed kbrock closed 1 year ago

kbrock commented 1 year ago

un-deprecate

un-deprecating has_ancestry in the middle of the tree punting on this to a later date.

Tests

BaseClass
- ChildClass1 (defined has_ancestry)
- ChildClass2 (also defines has_ancestry)

Ensure that ChildClass1 ancestry options do not leak over to ChildClass2 If there are multiple STI nodes that have ancestry defined.

Outstanding

[x] ~~depends upon #628 (or 600)~~
[x] ~~change test to ensure ancestry_options are different~~

See also #631 for stable backport

kshnurov commented 1 year ago

That's one more thing a #620 would break.

kbrock commented 1 year ago

That's one more thing a #620 would break.

Yup. I tried to think of any issues we could have in STI trees. This test was suspect and it got me thinking of other places bugs may lurk. @@variables are notorious for introducing bugs within hierarchies, let alone STI trees.