this is called after a save, no need to call new_record? (/via #589)
moving ancestry_changed? in the callback definition
had wanted to remove sane_ancestor_ids? since validations already ran
Unfortunately, update_attribute (read: no validations) allows bogus ancestry through.
Decided to continue skipping updates if the ancestry is deemed not valid.
It can only get this way if a user intentionally skips validations.
Not sure the desired behavior if something is corrupting ancestor's ancestry value.
I can see reason why we may want to propagate these changes.
For now, keeping this skip updates check in place
new_record?(/via #589)ancestry_changed?in the callback definitionsane_ancestor_ids?since validations already ran Unfortunately,update_attribute(read: no validations) allows bogus ancestry through.Decided to continue skipping updates if the ancestry is deemed not valid. It can only get this way if a user intentionally skips validations.
Not sure the desired behavior if something is corrupting ancestor's ancestry value. I can see reason why we may want to propagate these changes. For now, keeping this skip updates check in place