search

stefankroes / ancestry

Organise ActiveRecord model into a tree structure
MIT License
3.71k stars 458 forks source link

path_ids_in_database removed? #645

Closed rastamhadi closed 1 year ago

rastamhadi commented 1 year ago

ancestry 4.2.0 has #path_ids_in_database, but 4.3.0 doesn't. It was removed in #589, along with #ancestor_ids_in_database, which was addressed in #636. #ancestor_ids_in_database has since been restored in #637 and 4.3.1, but #path_ids_in_database is still gone.

I can't tell if #path_ids_in_database was meant to be part of the public interface, but I thought I'd just let you know about this potentially breaking change. There weren't any other issues asking about #path_ids_in_database so there may not be any demand for it to be restored.

PS: I have code that used to call #path_ids_in_database but I've since reworked it to call #ancestor_ids_in_database instead.

kbrock commented 1 year ago

@rastamhadi thank you for finding the issue and doing some great research. I will get this in.

kbrock commented 1 year ago

@rastamhadi released 4.3.2 Let me know if there are any other issues.

rastamhadi commented 1 year ago

tqvm! We should be doing a bundle update next week. I'll let you know how it goes :)

rastamhadi commented 1 year ago

We've upgraded to 4.3.2 and released to production without any problems! ❤️

kbrock commented 1 year ago

thanks so much for the followup. Let me know if you need anything else