search

stefankroes / scribble

Scribble is a customer facing template language similar to Liquid build in Ruby
MIT License
122 stars 7 forks source link

Add support for unless keyword. #1

Closed garymardell closed 9 years ago

garymardell commented 9 years ago

@stefankroes

Adds support for unless blocks to complement the if block.

stefankroes commented 9 years ago

Very cool! Thx! First pull request :tada:

I think it could be implemented a bit cleaner if you invert the condition before inserting it into the paths array:

send :elsif, !Registry.to_boolean(object)

Do you want to change it? I'm also willing to merge as is.

garymardell commented 9 years ago

You're right, that is a lot nicer. Still getting my head around all the node splitting.

I have changed it now. You should setup something like https://semaphoreapp.com/ to run the tests on PR's.

stefankroes commented 9 years ago

I'm planning to setup some CI and coverage reports soon. Merging.