search

stefankueng / grepWin

A powerful and fast search tool using regular expressions
https://tools.stefankueng.com/grepWin.html
GNU General Public License v3.0
1.74k stars 180 forks source link

Unwanted network connection #366

Closed mrx23dot closed 1 year ago

mrx23dot commented 1 year ago

After starting 2.0.13 my firewall complains that grepwin wants to talk on the internet,

even though 'check for updates' is disabled.

stefankueng commented 1 year ago

Does this happen during installation or after when you start grepWin?

stefankueng commented 1 year ago

and does your firewall show to which address it want's to talk to?

mrx23dot commented 1 year ago

after already installed:

2023-01-20_223132_gR

185.199.109.133: ISP: GitHub Inc. US

and it's halts and exits (but not always) if I don't let it talk, wasn't the case in earlier versions.

stefankueng commented 1 year ago

that's strange. The update check thread isn't even started if the option is disabled. And that's the only place in the grepWin code that establishes a network connection.

https://github.com/stefankueng/grepWin/blob/3d3acc612756adc8a48ee8523ddf4d94de6756b6/src/SearchDlg.cpp#L639-L648

stefankueng commented 1 year ago

can you check again if the option to check for updates is really disabled? Maybe the setting got lost during the update?

mrx23dot commented 1 year ago

Interesting, it still tries to connect first time I start grepwin.exe after reboot. 2023-01-23_205812_3U

update was never enabled: 2023-01-23_205845_ri

I don't see any 'github' relevant code in the repo, so maybe one of the libs/DLL? Also I can't find 'github' in exe if I open it in a hex editor.

stefankueng commented 1 year ago

I think I found the problem. You have to first check the option in the settings dialog, close grepWin, then open the settings dialog again and uncheck it. The problem is that the default is shown as "do not check" even though the default is "do check" everywhere else.

mrx23dot commented 1 year ago

Nice one, it works, as long it auto fixes it for everyone else in the next release it should be fine. Thanks!