search

stefankueng / grepWin

A powerful and fast search tool using regular expressions
https://tools.stefankueng.com/grepWin.html
GNU General Public License v3.0
1.76k stars 182 forks source link

Empty "Exclude dirs" and "File Names match" don't get saved correctly for presets #386

Closed Destroy666x closed 1 year ago

Destroy666x commented 1 year ago

Whenever you create new presets, extra "" are added inside excludedirs and filematch dirs in bookmarks file. Examples:

excludedirs=""""
filematch=""""
excludedirs=""""""""
filematch=""""""""

which is annoying because files get skipped if you don't notice this.

I'm using latest grepWIn 2.0.13.1197 version on Windows 10.

stefankueng commented 1 year ago

Not quite sure how you get multiple quotes listed. Are you starting grepWin with the /preset command line switch?

Destroy666x commented 1 year ago

I don't modify anything, except some settings, here's a screenshot: image Don't think they affect presets though.

Reproduction steps are basically this, from what I see:

  1. Fill text/regex search and replacement
  2. Test search
  3. Add to presets
  4. Fill some other search replace
  5. Choose the saved preset
  6. Fill something else again
  7. Test search and add as another preset
  8. bookmarks file has 4 quotes for mentioned fields for the new preset.

This is an example of a preset that was affected: image

stefankueng commented 1 year ago

the only way I can get to this is if I rename an existing bookmark. Just by adding/selecting them I can't reproduce this.

Destroy666x commented 1 year ago

Weird then, I got it on my first try yesterday. The name was "test for bug" if it matters. Today it didn't happen with the same steps and name. Could be because I had renamed preset selected in the app earlier? But yea, I see renaming causes it for me as well. Some of presets I had with a lot of " could have been caused by mostly renames as there were a few that I renamed multiple times.