stefankueng / grepWin

A powerful and fast search tool using regular expressions
https://tools.stefankueng.com/grepWin.html
GNU General Public License v3.0
1.76k stars 182 forks source link

Fix issue - Could not start an editor at a specific line #395

Closed markbullplus closed 1 year ago

markbullplus commented 1 year ago

Fix issue - Could not start an editor at a specific line

stefankueng commented 1 year ago

Thanks for the PR! But I think there's a better way to do this:

please have a look at my solution here https://github.com/stefankueng/grepWin/commit/34b1419d372e8f1729e630c7260616e6e2c353a5

markbullplus commented 1 year ago

Sure, it seems better.

------------------ 原始邮件 ------------------ 发件人: "stefankueng/grepWin" @.>; 发送时间: 2023年5月13日(星期六) 晚上8:56 @.>; @.**@.>; 主题: Re: [stefankueng/grepWin] Fix issue - Could not start an editor at a specific line (PR #395)

Thanks for the PR! But I think there's a better way to do this:

no need to store a full CSearchInfo in a map, just keep the idx/path map

get the line number not by parsing the list control but getting it from our stored data

please have a look at my solution here 34b1419

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>