stefanmielke / libdragon-extensions

List of structs and functions to help on Libdragon development.
MIT License
6 stars 1 forks source link

RDPQ basic changes #12

Closed adamcate closed 1 year ago

adamcate commented 1 year ago

This is a straightforward transition to RDPQ with no TMEM optimizations, etc. The main improvements at the moment are the ability to use and automatically configure multiple texture formats-- including color indexed formats--using format_handling.h's format_set_render_mode. I think this needs more testing before a merge, and tiled_cached still uses the old rendering system, hence why this is a draft PR

stefanmielke commented 1 year ago

Looks really good!

A few comments:

adamcate commented 1 year ago

Looks really good!

A few comments:

  • Do we plan to expose format_set_render_mode? If so, we may want to consider adding to the README.

  • Some of the variables with _0 and _1 could be replaced with position_int and width/height with size (not necessary, more like a cleanup really, and for size we may want a size_int).

  • We could add deprecated to tiled_cached if we feel comfortable removing it in a future version (or at least not giving any more time to improve it).

  • Some of the formatting is weird (like mixed tabs), you could configure your editor to use the .clang-format file we have on the root to fix that.

Thanks for the feedback. I initially added 'format_set_render_mode' for cleaner code but I think it would be great to expose that functionality to users. I'll test it and add it to the README. I'll definitely look into using positionint. I'll take a look at the formatting when I can as well.