stefano-m / lua-dbus_proxy

Simple API around GLib's GIO:GDBusProxy built on top of lgi
https://stefano-m.github.io/lua-dbus_proxy/
Apache License 2.0
17 stars 7 forks source link

fix unpack for luajit #5

Closed unai-ndz closed 4 years ago

unai-ndz commented 4 years ago

table.unpack is only available on lua >= 5.2.

This makes dbus_proxy also work with ~lua 5.1~ luajit, some tests will still fail with lua 5.1.

codecov[bot] commented 4 years ago

Codecov Report

Merging #5 into master will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   89.53%   89.58%   +0.04%     
==========================================
  Files           5        5              
  Lines         239      240       +1     
==========================================
+ Hits          214      215       +1     
  Misses         25       25              
stefano-m commented 4 years ago

Hello,

thanks for your interest in this project and your contribution and sorry for the very late reply.

I am a little reluctant in including this change because I would be unable to support Lua 5.1 properly.

Would you be willing to add a Lua 5.1 configuration to the .travis.yml file so we can at least run tests against it?

Thanks.

unai-ndz commented 4 years ago

As travis has shown, support for lua 5.1 will need a few more changes and I'm actually using luajit which I think is the only advantage of not running a newer version.

stefano-m commented 4 years ago

Pulled in by 412ff3ebeb1569dd056f7c88fb24f803d3f2e834

Thank you!