Closed unai-ndz closed 4 years ago
Merging #5 into master will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 89.53% 89.58% +0.04%
==========================================
Files 5 5
Lines 239 240 +1
==========================================
+ Hits 214 215 +1
Misses 25 25
Hello,
thanks for your interest in this project and your contribution and sorry for the very late reply.
I am a little reluctant in including this change because I would be unable to support Lua 5.1 properly.
Would you be willing to add a Lua 5.1 configuration to the .travis.yml
file so we can at least run tests against it?
Thanks.
As travis has shown, support for lua 5.1
will need a few more changes and I'm actually using luajit
which I think is the only advantage of not running a newer version.
Pulled in by 412ff3ebeb1569dd056f7c88fb24f803d3f2e834
Thank you!
table.unpack
is only available onlua >= 5.2
.This makes
dbus_proxy
also work with ~lua 5.1
~luajit
, some tests will still fail withlua 5.1
.