🇫🇷 Add French translation

stefanobartoletti commented 3 years ago

🇫🇷 A French translation should be added 🇫🇷

To contribute, follow these simple rules:

The translation should be located inside the /languages folder and created/edited with Poedit.
The translation file should be named fr_FR.po and created by starting from the template.pot template.
Poedit should be set to automatically create .mo file.
You can use the already present italian translation as an example for your work.
The translation should be made by a native or fluent speaker of the said language, not by using automated online tools like Google Translate or similar (I could do this myself, I'm looking for a more tailored contribution).
Before translating strings, make sure to check the context where they will be displayed. After your translation work, run the local development environment to check if they are correct and make sense in-place (detailed installation instructions are available in the Docs)
Ideally, the creator of a new translation should keep it updated also in future versions of Bricks (this is not required but strongly recommended. It should be a manageable task, it is not a lot of work).

🏵️ Thank you for your contribution and happy Hacktoberfest! 🏵️

Tititesouris commented 2 years ago

Hi, French native speaker here, I'll gladly take on this task :) I'll start translating and will let you know if I have questions regarding the context & specific meaning of some sentences.

stefanobartoletti commented 2 years ago

Thank you for your contribution, let me know if you need some help.

Would you be interested in keeping the translation updated even in future versions of Bricks? (I don't usually make new releases very often, a new version ever month at most, and usually not every update modifies translations).

Tititesouris commented 2 years ago

Sure, you can always ping me, and I'm sure I can find some time to update them.

I already have my first question Where English usually likes to capitalize every word, French usually avoids that. Do you prefer to keep the English-style, or to adapt the case? So for instance:

"Example: Street, Number" could be either "Exemple : Rue, Numéro" or "Exemple : rue, numéro"

"Newer Comments →" could be either "Commentaires Plus Récents →" or "Commentaires plus récents →"

For the first example, I think either would look ok to a French person. For the second, I think French people might be caught off-guard by the unnecessary capitalization.

stefanobartoletti commented 2 years ago

I don't have any strict rule about capitalization, so you can probably choose the version that feels more natural in your language.

Tititesouris commented 2 years ago

I think I found a typo in the template and subsequently in the German and Italian translations. The key 'Example: https//goo.gl/maps/sNAFh8SNCLH5cYyL7 for Google Maps' does not contain the colon ':' after 'https'. Meaning the link is broken. I imagine it should be 'https://goo.gl/maps/sNAFh8SNCLH5cYyL7', as this link points to the Metropolitan City of Bologna. Should I open a separate PR to fix the template and the other languages?

stefanobartoletti commented 2 years ago

Thank you for reporting this, it is indeed a mistake. I'm going to fix the .pot template myself (it needs to be generated starting from PHP files), but you can fix the other languages. Please use a single PR as this is a single issue.

Thanks!

stefanobartoletti commented 2 years ago

Here it is, the correct template is on devel branch, you can go on with the translation files

stefanobartoletti commented 2 years ago

Hi @Tititesouris, I'd like to let you know that I'm planning a new release with the contributions made during Hacktoberfest in early November, including giving full credits to contributors.

If you are still working on this it would be nice to include your PR as well :)

Tititesouris commented 2 years ago

Hi @stefanobartoletti Yes, sorry I've been so silent, I've been very busy. I'll try to get the PR done asap :)

stefanobartoletti commented 2 years ago

No problem, I wrote only to let you know what my plans are, but feel free to set your own priorities.

If you can't work on it right now I can include this in a future release, no problem at all.

Thank you ✌️

Tititesouris commented 2 years ago

Hey there, another question for you. The key "Main Sidebar" would be perfectly translated as "Barre de navigation latérale principale". This is quite a mouthful. There are a few things that could be done to improve it:

If there is no "main" and "additional" sidebars, there's no need to specify that it's a "main" sidebar, and we could drop the "principale".
If "Lateral navigation" is also a good description of that feature, then we could get away with just "Navigation latérale".
If your target audience is people versed in computer science, then the term Sidebar is known, and we could simply use "Sidebar" or "Sidebar principale".

What is your favorite/least favorite option?

Tititesouris commented 2 years ago

And another question regarding the key "It seems we can’t find what you’re looking for. Perhaps searching can help." To me it seems to just say "Your search didn't yield any results. Try searching", which doesn't seem right 😅 What's the context here? If it doesn't appear when searching, where does it appear? Thanks

stefanobartoletti commented 2 years ago

About the sidebar:

Keep in mind that this is just a starter theme, it is a starting point for developers to create their own setup. "Main" in this context mean that other sidebars are likely to be added.
I think that Sidebar is a recognized term, there is no need to translate it at all costs. In the Italian translation, I just kept it that way https://github.com/stefanobartoletti/bricks/blob/master/languages/it_IT.po

About the other string, it is not displayed when an user manually searches, but when for some reasons the internal WordPress query fails to retrieve items. It happens very rarely, I agree that the wording is not 100% clear, but at the moment it serves the purpose and in-context is less confusing that reading it alone. You can translate it just like that.

Anyway, thank you very much for how seriously you are taking this!

Tititesouris commented 2 years ago

Alright thank you for the fast responses. Then a final question before I can make the PR: Do I need to escape apostrophes (') in my translations the same way it is escaped in the source text of "Oops, that page can't be found"? Oops, that page can't be found

stefanobartoletti commented 2 years ago

Yes it is probably best to escape them, there should be no problems but as they say, better safe than sorry.

Thanks!

stefanobartoletti / bricks

🇫🇷 Add French translation #112