stefanobartoletti
commented
6 months ago Hi @memory-lovers, thanks for this, and first of all no worries, your english is very good and the message was clear and polite :)
I had a look at your proposed PR, and it looks good to me, but there are some notes before submitting it:
- I would prefer to have a dedicated PR for each proposed service instead of a catch-all. That way, if some edits or fixing will be required, it will be easier to review and to keep everything in scope.
About the proposed networks:
- Including Line is ok, as it is a widespread messaging app. I'm not using it personally, so I need to ask you to double-check if the URL is working as expected. Then you can proceed with a dedicated PR.
- About Bluesky, I never heard about it before, but judging from the app in the Play Store, it seems to be quite popular. Even here, please check if the share URL is working before opening a PR.
- For Hatena, I am not sure if it is a good fit for inclusion at this moment. As far as I can see, the linked site is only in Japanese (If I am not wrong) and I cannot find some reference in English. I am a bit reluctant to include code where I cannot personally read documentation, even for something as trivial as a share URL: in this context, it will be very hard for me to ensure future maintainability should the API change or if issues arise that need to be addressed. Also, judging by their social accounts, it seems that it is not as widespread as other services included in this module. I'm sorry, but for this specific service at the moment I have to reject the inclusion.
Please note that I was also thinking about including a way to use a customized network, but a the moment it is just an idea. If implemented, I will work on it no sooner than Nuxt 4 will be released. But maybe that could cover your specific need.
Anyway, thanks for this valuable contribution, I really appreciated that you also included links to the apps' docs for reference!
memory-lovers
Thank you for your great package!!
Describe your suggestion
I would like to share to below SNS.
Use cases
I would like to support new networks.
Describe alternatives you've considered
I couldn't find any good ideas..
Additional context
Specifications and Color for each SNS are below.
https://line.me/R/share?text=[u](ref)#06C755(ref)https://bsky.app/intent/compose?text=[u](ref)#1185FEhttps://b.hatena.ne.jp/entry?url=[u](ref)#00A4DE(ref)And, I'm developing this feature a bit. If you don't mind, can I submit a PR?
P.S. I'm not good at English, and this is my first issue. Forgive me if I make you feel bad by using incorrect words in English, i don't mean it at all.