bootstrap dependency install the second bootstrap module

[Tolsi]

I have used in my project package mizzao: bootstrap-3 and after the installation of this package some page elements stopped working due to the presence of two bootstrap.js files in the page. This error was difficult to catch. Maybe to give the user to choose bootrap package that he wants to use and remove that because of dependencies?

[stefanocudini]

I think you should to edit the file package.json before of npm install

May be then replace my deps with your custom boostrap

[Tolsi]

I just make meteor add mrt:bootstrap-list-filterto install and I can't edit the package dependencies.

[stefanocudini]

mm yes I understood.. Do you think that the best way is completely remove deps in package.json and smart.json??

[Tolsi]

Maybe just delete dependency in configs and write in readme that you must manually add bootsrap package?

[stefanocudini]

in the majority of cases, I think it is useful to include dependencies in pkg.json

[Tolsi]

I think that anyone who installs this package already has some developments with bootstrap and already install it. But your package - your rules.

[stefanocudini]

maybe, thanks for your suggestions! I now want to add some new features, and after I'll think better about this

[jfgodoy]

this issue can be solved using npm peerDependencies

  "peerDependencies": {
    "bootstrap": "^3.4.5"
  }

[stefanocudini]

@jfgodoy https://github.com/stefanocudini/bootstrap-list-filter/commit/de147390e5b7c072b806dec55e4a9061b965b60a

[jfgodoy]

@stefanocudini, I put that script using the last version of bootstrap as example. I think your proyect is compatilbe with old versions of bootstrap. Also remember to remove the bootstrap dependency from dependencies property.