stefanocudini / leaflet-search

Search stuff in a Leaflet map
https://opengeo.tech/maps/leaflet-search/
MIT License
780 stars 335 forks source link

Fix broken JSONP. #322

Closed svbatalov closed 1 year ago

svbatalov commented 1 year ago

Fixes #321

E-gy commented 1 year ago

Just further noting that this also fixes the exactly similar issue with Ajax mode (since _retrieveData is either _recordsFromJsonp or _recordsFromAjax, both with same signature).

That's issue #318.

E-gy commented 1 year ago

It seems to have broken in 3.0.9, as arguments are correct in 3.0.5 - which thus works as a temporary workaround. image

stefanocudini commented 1 year ago

It seems to have broken in 3.0.9, as arguments are correct in 3.0.5 - which thus works as a temporary workaround.

I'll check and merge soon, tnks!

stefanocudini commented 1 year ago

@svbatalov this merge cause this problem: image

mikelcp commented 9 months ago

@stefanocudini any updates on my pr? It should resolve this