search

stefanocudini / leaflet-search

Search stuff in a Leaflet map
https://opengeo.tech/maps/leaflet-search/
MIT License
772 stars 334 forks source link

Geocoding examples broken #324

Closed cw-code-1 closed 11 months ago

cw-code-1 commented 1 year ago

Hi, the google geocoding example and the nominatim geocoding example are not working for me.

There is an error on loading, https://opengeo.tech/labs-common.js not found, but I don't think this needed.

Note that this plugin is included in the leaflet-ui plugin and it works there, it is using Leaflet Control Search v3.0.0 - 2021-08-18.

I will try digging into it tomorrow.

jt196 commented 1 year ago

@cw-code-1 see issue #321 and PR #322. Even with the fix proposed in the latter, I'm still getting an undefined search result.

Interestingly, the Google example is producing a different error InvalidValueError: in property address: not a string to the OSM example: L.Control.Search.callJsonp is not a function, though the cause may be related.

jt196 commented 1 year ago

image

I've ended up writing my own...

stefanocudini commented 1 year ago

@jt196 caused by some last PR merged: https://github.com/stefanocudini/leaflet-search/pull/322#issuecomment-1669310213

I don't have much time to follow this but if someone wants to fix the little problem I'll merge and publish to npm quickly

stefanocudini commented 11 months ago

solved