search

stefanofontanelli / ColanderAlchemy

ColanderAlchemy helps you autogenerating Colander schemas based on SQLAlchemy mapped objects.
Other
63 stars 33 forks source link

Make it possible to set "unknown" using __colanderalchemy_config__ #78

Closed elemoine closed 9 years ago

elemoine commented 9 years ago

This commit makes it possible to set the unknown argument passed to colander.Mapping using __colanderalchemy_config__. This is useful when one wants to set unknown (to 'raise' or 'preserve') for classes used in a relationship.

Please tell me if more changes are required.

tisdall commented 9 years ago

Nice! Can you double check the docs to see if there's anywhere that change should be added in? Also, please update the CHANGES.rst with a comment about the new change.

elemoine commented 9 years ago

Nice! Can you double check the docs to see if there's anywhere that change should be added in? Also, please update the CHANGES.rst with a comment about the new change.

Thanks for the review.

I updated CHANGES.rst and added a note to the customization doc page. The note is similar to what's in the docstrings of SQLAlchemySchemaNode#init, but I think it's worth having it there as well.

elemoine commented 9 years ago

Thanks.

tisdall commented 9 years ago

Thanks for the addition!